Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

@dreinon
Copy link
Contributor

@dreinon dreinon commented Jan 2, 2022

Inherit from Exception instead of from BaseException.
More info: https://docs.python.org/3/tutorial/errors.html#tut-userexceptions

Thanks for the report: @ktosiek

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 2, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 5.46 ⭐ 5.46 ⭐ 0.00
Method Length 31.40 ⭐ 31.40 ⭐ 0.00
Working memory 4.96 ⭐ 4.96 ⭐ 0.00
Quality 80.70% 80.70% 0.00%
Other metrics Before After Change
Lines 41 41 0
Changed files Quality Before Quality After Quality Change
gotrue/exceptions.py 80.70% ⭐ 80.70% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@dreinon dreinon requested a review from a team January 2, 2022 20:21
@leynier leynier merged commit f415aa0 into main Jan 2, 2022
@leynier leynier deleted the inherit-from-exception branch January 2, 2022 22:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants