Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

@leynier
Copy link
Contributor

@leynier leynier commented Jan 4, 2022

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 4, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.09%.

Quality metrics Before After Change
Complexity 4.04 ⭐ 4.04 ⭐ 0.00
Method Length 44.71 ⭐ 44.90 ⭐ 0.19 👎
Working memory 7.32 🙂 7.34 🙂 0.02 👎
Quality 74.82% 🙂 74.73% 🙂 -0.09% 👎
Other metrics Before After Change
Lines 1424 1426 2
Changed files Quality Before Quality After Quality Change
gotrue/_async/client.py 74.31% 🙂 74.24% 🙂 -0.07% 👎
gotrue/_sync/client.py 74.60% 🙂 74.53% 🙂 -0.07% 👎
tests/_async/test_client_with_sign_ups_disabled.py 75.84% ⭐ 75.68% ⭐ -0.16% 👎
tests/_sync/test_client_with_sign_ups_disabled.py 75.99% ⭐ 75.82% ⭐ -0.17% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gotrue/_async/client.py AsyncGoTrueClient.get_session_from_url 15 🙂 219 ⛔ 14 😞 36.39% 😞 Try splitting into smaller methods. Extract out complex expressions
gotrue/_sync/client.py SyncGoTrueClient.get_session_from_url 15 🙂 217 ⛔ 14 😞 36.53% 😞 Try splitting into smaller methods. Extract out complex expressions
gotrue/_async/client.py AsyncGoTrueClient.sign_in 11 🙂 115 🙂 10 😞 56.40% 🙂 Extract out complex expressions
gotrue/_sync/client.py SyncGoTrueClient.sign_in 11 🙂 108 🙂 10 😞 57.31% 🙂 Extract out complex expressions
gotrue/_async/client.py AsyncGoTrueClient.__init__ 3 ⭐ 89 🙂 16 ⛔ 58.56% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #52 (467fa3f) into main (d012ae8) will increase coverage by 0.96%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   79.88%   80.85%   +0.96%     
==========================================
  Files          14       14              
  Lines        1054     1055       +1     
==========================================
+ Hits          842      853      +11     
+ Misses        212      202      -10     
Impacted Files Coverage Δ
gotrue/exceptions.py 65.71% <11.11%> (-0.96%) ⬇️
gotrue/__init__.py 100.00% <100.00%> (ø)
gotrue/_async/client.py 89.12% <100.00%> (+7.60%) ⬆️
gotrue/_sync/client.py 89.12% <100.00%> (+7.60%) ⬆️
gotrue/_sync/api.py 59.88% <0.00%> (-7.56%) ⬇️
gotrue/_async/api.py 59.88% <0.00%> (-7.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 293065c...467fa3f. Read the comment docs.

@leynier leynier merged commit 4c05816 into supabase:main Jan 4, 2022
@leynier leynier deleted the fix/deploy-action branch January 4, 2022 05:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant