Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

@zodman
Copy link
Contributor

@zodman zodman commented Jan 13, 2022

because the intention is good but instead receives an annoying print.

because the intention is good but instead receives an annoying print.
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 13, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 5.11 ⭐ 5.11 ⭐ 0.00
Method Length 44.13 ⭐ 44.13 ⭐ 0.00
Working memory 7.65 🙂 7.65 🙂 0.00
Quality 74.53% 🙂 74.53% 🙂 0.00%
Other metrics Before After Change
Lines 599 599 0
Changed files Quality Before Quality After Quality Change
gotrue/_sync/client.py 74.53% 🙂 74.53% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gotrue/_sync/client.py SyncGoTrueClient.get_session_from_url 15 🙂 217 ⛔ 14 😞 36.53% 😞 Try splitting into smaller methods. Extract out complex expressions
gotrue/_sync/client.py SyncGoTrueClient.sign_in 11 🙂 108 🙂 10 😞 57.31% 🙂 Extract out complex expressions
gotrue/_sync/client.py SyncGoTrueClient.__init__ 3 ⭐ 89 🙂 16 ⛔ 58.56% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #61 (044d959) into main (2f94bfd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files          14       14           
  Lines        1055     1055           
=======================================
  Hits          879      879           
  Misses        176      176           
Impacted Files Coverage Δ
gotrue/_sync/client.py 89.12% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f94bfd...044d959. Read the comment docs.

@leynier
Copy link
Contributor

leynier commented Jan 13, 2022

@zodman please, can you make the change in _async section and execute the make build_sync command?

@leynier leynier changed the title Update client.py chore: fix http warning use Jan 13, 2022
@leynier leynier merged commit ae20a8e into supabase:main Jan 13, 2022
@leynier
Copy link
Contributor

leynier commented Jan 13, 2022

@zodman thank you very much for your contribution

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants