fix: delete_user returns Exception event if response is Ok (Sourcery refactored)

[sourcery-ai]

Pull Request #68 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the fix/delete-user-returns-exception-event-if-response-is-ok branch, then run:

git fetch origin sourcery/fix/delete-user-returns-exception-event-if-response-is-ok
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Function AsyncGoTrueAPI.__init__ refactored with the following changes:

• Simplify if expression by using or (or-if-exp-identity)

[sourcery-ai]

Function AsyncGoTrueAPI.sign_in_with_phone refactored with the following changes:

• Inline variable that is only used once (inline-variable)
• Move assignment closer to its usage within a block (move-assign-in-block)
• Simplify unnecessary nesting, casting and constant values in f-strings (simplify-fstring-formatting)

[sourcery-ai]

Function AsyncGoTrueAPI.refresh_access_token refactored with the following changes:

• Inline variable that is only used once (inline-variable)
• Move assignment closer to its usage within a block (move-assign-in-block)
• Simplify unnecessary nesting, casting and constant values in f-strings (simplify-fstring-formatting)

[sourcery-ai]

Function SyncGoTrueAPI.__init__ refactored with the following changes:

• Simplify if expression by using or (or-if-exp-identity)

[sourcery-ai]

Function SyncGoTrueAPI.sign_in_with_phone refactored with the following changes:

• Inline variable that is only used once (inline-variable)
• Move assignment closer to its usage within a block (move-assign-in-block)
• Simplify unnecessary nesting, casting and constant values in f-strings (simplify-fstring-formatting)

[sourcery-ai]

Function SyncGoTrueAPI.refresh_access_token refactored with the following changes:

• Inline variable that is only used once (inline-variable)
• Move assignment closer to its usage within a block (move-assign-in-block)
• Simplify unnecessary nesting, casting and constant values in f-strings (simplify-fstring-formatting)

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.24%.

Quality metrics	Before	After	Change
Complexity	0.78 ⭐	0.79 ⭐	0.01 👎
Method Length	40.40 ⭐	39.98 ⭐	-0.42 👍
Working memory	6.58 🙂	6.50 🙂	-0.08 👍
Quality	83.24% ⭐	83.48% ⭐	0.24% 👍

Other metrics	Before	After	Change
Lines	1232	1228	-4

Changed files	Quality Before	Quality After	Quality Change
gotrue/_async/api.py	83.18% ⭐	83.42% ⭐	0.24% 👍
gotrue/_sync/api.py	83.31% ⭐	83.55% ⭐	0.24% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!