feat: add notion to enum of providers (Sourcery refactored) #71
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| if "access_token" in response.json(): | ||
| return Session | ||
| return User | ||
| return Session if "access_token" in response.json() else User |
There was a problem hiding this comment.
Function determine_session_or_user_model_from_response refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.37%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Codecov Report
@@ Coverage Diff @@
## feat/add-notion-to-enum-of-providers #71 +/- ##
========================================================================
- Coverage 84.22% 84.19% -0.04%
========================================================================
Files 14 14
Lines 1052 1050 -2
========================================================================
- Hits 886 884 -2
Misses 166 166
Continue to review full report at Codecov.
|
* feat: add notion to enum of providers * 'Refactored by Sourcery' (#71) Co-authored-by: Sourcery AI <> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Pull Request #70 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
feat/add-notion-to-enum-of-providersbranch, then run:Help us improve this pull request!