fix: reloader unittest races on writeWg #2352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
writeWg.Add was being called after after a call to writerWg.Wait.
jnschaeffer
approved these changes
Jan 26, 2026
Pull Request Test Coverage Report for Build 21359244319Details
💛 - Coveralls |
cstockton
pushed a commit
that referenced
this pull request
Jan 28, 2026
🤖 I have created a release *beep* *boop* --- ## [2.186.0](v2.185.0...v2.186.0) (2026-01-28) ### Features * Add email send operation metrics ([#2311](#2311)) ([0096575](0096575)) * add Supabase Auth identifier to OAuth redirect URLs ([#2299](#2299)) ([2d3dbc6](2d3dbc6)) * log sb-auth-user-id, sb-auth-session-id, ... on sign in not just refresh token ([#2342](#2342)) ([a486ada](a486ada)) * **oauth-server:** store and enforce token_endpoint_auth_method ([#2300](#2300)) ([bcd6cd5](bcd6cd5)) * replace JWT OAuth state with `flow_state.id` UUID ([#2331](#2331)) ([645654d](645654d)) * upgrade existing sessions to v2 refresh tokens though config value ([#2356](#2356)) ([6fb0e8a](6fb0e8a)) ### Bug Fixes * reloader unittest races on writeWg ([#2352](#2352)) ([088b714](088b714)) * update migration version ([#2343](#2343)) ([61ef4db](61ef4db)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: supabase-releaser[bot] <223506987+supabase-releaser[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for
writerWg.Add(1)to race with thenotifyFnpassed ineg.Go's call topr.watch. Simple fix is incrementing after writeWg is initialized.