fix: promise returned by getRuntimeMetrics never resolved
#573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laktek
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Description
v8 Isolate has a flag internally to check if a pending interruption request exists, but this flag is recorded as thread-local state, and if Isolate is executed in another thread by a locker, this state does not carry over.
Therefore, in edge-runtime, lines existed to force the interruption flag to be set by calling a dummy interruption request under certain conditions, but when interruptions were requested via op_runtime_metrics, this flag was not set due to a subtle issue.
As a result, the interruption callback was never called and the promise never transitioned to the resolved state.
This PR fixes these issues.