fix(base/server): return HTTP error responses instead of dropping connection in WorkerService#696
Merged
nyannyacha merged 3 commits intomainfrom Apr 24, 2026
Merged
Conversation
…nection in WorkerService
nyannyacha
changed the title
johnstonmatt
approved these changes
Apr 24, 2026
nyannyacha
force-pushed
the
ny/server-improvement
branch
from
3a31ef5 to
4146ba1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Improvement
Description
Fixed two cases in
WorkerServicewhere the TCP connection was dropped without sending an HTTP response when the worker failed to respond.res_rx.awaitfailure (worker dropped the oneshot sender) -> now returns 500 instead of dropping the connectioncancel.is_cancelled()after awaiting response -> now returns 503 instead of dropping the connectionDropping the TCP connection without a response causes ELB to report 502 Bad Gateway even when the worker process itself is still alive, resulting in spurious 502s.
Both cases now include
x-served-by: base/serverheader to distinguish responses handled at the HTTP server layer from those served by the worker.