Skip to content

fix(deno_facade): should not assume that all module paths to be extracted have the same prefix #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

fix(deno_facade): should not assume that all module paths to be extracted have the same prefix #639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions crates/deno_facade/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,10 @@ async fn create_module_path(
output_folder: &Path,
) -> PathBuf {
let cleaned_specifier = strip_file_scheme(global_specifier);
let cleaned_specifier =
cleaned_specifier.replace(entry_path.to_str().unwrap(), "");
let module_path = PathBuf::from(cleaned_specifier);
let cleaned_path =
pathdiff::diff_paths(&*cleaned_specifier, entry_path).unwrap();

if let Some(parent) = module_path.parent() {
if let Some(parent) = cleaned_path.parent() {
if parent.parent().is_some() {
let output_folder_and_mod_folder = output_folder.join(
parent
Expand All @@ -68,9 +67,9 @@ async fn create_module_path(
}

output_folder.join(
module_path
cleaned_path
.strip_prefix("/")
.unwrap_or_else(|_| ensure_unix_relative_path(&module_path)),
.unwrap_or_else(|_| ensure_unix_relative_path(&cleaned_path)),
)
}

Expand Down
Loading