fix(test): resolve edge function test typo and invalid branch array access#279
Merged
gregnr merged 2 commits intoMay 15, 2026
Merged
Conversation
57fd7b6 to
6f9ee36
Compare
Member
|
(e2e tests are failing due to API key - we'll merge as is) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
delete branchtest case inserver.test.tsfails in standard JavaScript environments due to an invalid negative array indexbranches[-1].eploy edge function validates slug format.What is the new behavior?
branches[-1]with the modern JavaScript.at(-1)method to safely access the last element of the array.eploytodeploy.Additional context
These issues were identified while implementing new database tools. Resolving them ensures a stable test suite for all contributors.