fix: guard sessionStorage read in Socket constructor#35
Merged
Conversation
ffe7a26 to
8b63fa6
Compare
filipecabaco
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defense-in-depth fix for the bug reported in supabase/supabase-js#2331.
socket.js:62readsglobal.sessionStoragevia a bare property access. In sandboxed iframes withoutallow-same-origin, certain in-app webviews (Facebook Messenger, Instagram, Google Performance Max), and "block third-party storage" privacy modes, the property getter itself throwsSecurityErrorbefore||short-circuit evaluation completes — taking down the entireSocketconstructor synchronously.This wraps the read in
try/catchso the constructor cannot throw. Behavior is unchanged in every path that previously worked:nullis the fallback, and downstream call sites already guardthis.sessionStore && this.sessionStore.getItem(...)(socket.js:394, 396).Test plan
window.sessionStoragegetter to throw, then constructnew Socket(...)— expect no throw.Note: source-only change. Bundled assets under
priv/static/need a separate rebuild commit (per recurringfix: rebuild assetspattern, e.g. 8b8c7b2).