fix(typescript): union unknown null #995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soedirgo
approved these changes
Oct 5, 2025
avallete
merged commit 8b65b39
into
feat/add-functions-setof-type-introspection-v2
6 checks passed
avallete
added a commit
that referenced
this pull request
Oct 16, 2025
* feat(typegen): add setof function type introspection - Introspect the setof function fields for functions - Restore functions as unions of args + returns * chore: update snapshots * chore: unify sort and dedup loops * chore: remove duplicate sort * chore: include view in type * fix: isOneToOne * fix: tests * chore: dedup typescript typegen logic * chore: re-use generateColumn * fix: retrieve prorows only * chore: refactor typegen for prorows only * fix: only get reltype in types * chore: reuse relationTypeByIds * chore: reduce functions changes to minimum * chore: only single loop for types * chore: single sort for relationships * chore: reduce loops * fix: relationtype setof functions generation * chore: fix prettier * chore: update snapshots * chore: fix types test * fix: test types * fix: include materializedView types * test: add search_todos_by_details function * fix: add setof from * for all relation functions * fix(typescript): union unknown null (#995) * fix(typescript): unknown is already nullable Fixes: supabase/cli#4234 supabase/cli#577 * fix: also exclude any from null union
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unknownandanyalready swallow nullable type, don't need an union for it, in such case we follow tslint best practice:https://typescript-eslint.io/rules/no-redundant-type-constituents/
Fixes: