feat: peep storage for PromEx #1636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipecabaco
approved these changes
Dec 2, 2025
Member
|
🎉 This PR is included in version 2.67.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
prom_exfor peep storage support anddetach_on_erroroption for Polling metricsMetricsCleanerto work with Peep ETS tables. UsingPeep.prune_tagsThe new
detach_on_errorwon't stop the metrics from being polled if some error happens. See akoutmos/prom_ex@3feeceb#diff-959125153935b888fdba477b47b489f0d82c179dd2c03414efd530f6c170d3c5 for more detailsWe ended up defining our own "Store" module but simply to set the Peep internal storage to
stripedand settingglobal_tags.