fix: Add test coverage to repo; delete cdc stream; improve ReplicationConnection lifecycle #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
filipecabaco
force-pushed
the
fix/add-coverage
branch
4 times, most recently
from
300a5c6 to
b3e202e
Compare
filipecabaco
changed the title
filipecabaco
force-pushed
the
fix/add-coverage
branch
7 times, most recently
from
baf9915 to
5294790
Compare
* Attempt to send coverage to coveralls - https://coveralls.io/github/supabase/realtime * Removes CDC Stream code * Fix small compilation error with Gettext deprecation warnings * Renamed Realtime.Tenants.BroadcastChanges.Handler to Realtime.Tenants.ReplicationConnection * Reverses PID monitoring so Realtime.Tenants.ReplicationConnection and Realtime.Tenants.Listen are the ones tracking Realtime.Connect and die accordingly, reducing probability of process linking issues * Fixed Realtime.Tenants.Connect.shutdown/1 that was killing the Postgrex connection instead of killing Realtime.Tenants.Connect potentially leading to issues in the state of the connection
filipecabaco
force-pushed
the
fix/add-coverage
branch
from
5294790 to
3d04303
Compare
Member
Author
|
🚀 |
Member
|
🎉 This PR is included in version 2.33.81 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Realtime.Tenants.BroadcastChanges.HandlertoRealtime.Tenants.ReplicationConnectionRealtime.Tenants.ReplicationConnectionandRealtime.Tenants.Listenare the ones trackingRealtime.Connectand die accordingly, reducing probability of process linking issuesRealtime.Tenants.Connect.shutdown/1that was killing thePostgrexconnection instead of killingRealtime.Tenants.Connectpotentially leading to issues in the state of the connection