chore: enhance log lack of connections #1370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way it's a bit more clear what's going on
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
edgurgel
force-pushed
the
chore/enhance-log-lack-of-connections
branch
from
7d1ac6f to
ddcbd78
Compare
filipecabaco
approved these changes
May 13, 2025
Member
|
this should be a fix branch and fix title so we merge it and triggers version bump of patch |
filipecabaco
approved these changes
May 13, 2025
Member
Author
|
Closing in favour o #1373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Log the amount of required connections so it's clear why Realtime refused to connect.
What is the current behavior?
RealtimeChannel logs the following:
realtime/lib/realtime_web/channels/realtime_channel.ex
Lines 135 to 137 in 1ffc07d
Maybe the above can be removed given that now we will log at the
Database.check_tenant_connectionlevel?What is the new behavior?
Additional context