feat: add basic opentelemetry setup #1386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
2 tasks
filipecabaco
approved these changes
May 28, 2025
edgurgel
force-pushed
the
feat/opentelemetry-setup
branch
from
f47e865 to
4f65d43
Compare
edgurgel
commented
May 28, 2025
| run: mix hex.audit | ||
| - name: Run mix_audit | ||
| run: mix deps.audit --ignore-advisory-ids GHSA-vq52-99r9-h5pw | ||
| run: mix deps.audit --ignore-advisory-ids GHSA-vq52-99r9-h5pw,GHSA-9fm9-hp7p-53mf |
Member
Author
There was a problem hiding this comment.
The dependency doesn't seem to be used so no risk here. To be removed here #1390
It sets up opentelemetry for phoenix, ecto and cowboy. * No custom traces are added. * Span attributes are set for request_id and external_id update version
edgurgel
force-pushed
the
feat/opentelemetry-setup
branch
from
81e827f to
0b87e5f
Compare
Member
|
🎉 This PR is included in version 2.36.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
It sets up opentelemetry for phoenix, ecto and cowboy.
What is the current behavior?
No Opentelemetry.
What is the new behavior?
Basic opentelemetry for phoenix requests
Additional context
The first step of the original PR here: #1378