fix: replicate pg_output issue #1625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
filipecabaco
force-pushed
the
fix/pg-output-fix
branch
from
bbf58e2 to
935d826
Compare
If the string size matches the uuid length we were parsing it to be uuid which created issues. Now we validate first that the binary can be a string and if not we know it's a UUID value that can be converted
filipecabaco
force-pushed
the
fix/pg-output-fix
branch
from
935d826 to
8d91a46
Compare
filipecabaco
force-pushed
the
fix/pg-output-fix
branch
from
ef12700 to
3753d2b
Compare
edgurgel
reviewed
Nov 25, 2025
edgurgel
reviewed
Nov 25, 2025
edgurgel
approved these changes
Nov 25, 2025
Member
edgurgel
left a comment
edgurgel
left a comment
There was a problem hiding this comment.
Added a couple of comments! LGTM
filipecabaco
force-pushed
the
fix/pg-output-fix
branch
from
705a2c9 to
459211e
Compare
Member
|
🎉 This PR is included in version 2.65.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
If the string size matches the uuid length we were parsing it to be uuid which created issues. To prevent it we now handle payload based on the relations provided and we further simplified the logic to not use send in our message handling