fix: support bare array format for SUPABASE_JWKS#8
Merged
Conversation
The platform provides JWKS as a JSON array [...] but parseJwks
expected { keys: [...] }. Now wraps bare arrays automatically.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verifies parsing of real platform env var shapes: multiple named keys and bare JWKS array with two EC key entries. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates environment resolution to accept Supabase’s SUPABASE_JWKS value when provided as a bare JSON array (in addition to the standard { keys: [...] } JWKS shape), and adds tests to cover the new parsing behavior and realistic platform env var strings.
Changes:
- Extend
parseJwksto auto-wrap a bare array into{ keys: [...] }. - Add a unit test for bare-array JWKS parsing.
- Add an integration-style env parsing test for multi-key platform env vars plus JWKS array.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/core/resolve-env.ts |
Wraps parsed JWKS arrays into { keys: [...] } to support Supabase’s platform env var format. |
src/core/resolve-env.test.ts |
Adds coverage for bare-array JWKS parsing and a realistic platform env var scenario. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reject valid JSON that isn't a valid JWKS (e.g. primitives, empty objects, objects with non-array `keys`) instead of blindly casting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kallebysantos
approved these changes
Mar 20, 2026
Member
kallebysantos
left a comment
kallebysantos
left a comment
There was a problem hiding this comment.
Looks good to me!!
its similar to this other commit from ingress
This was referenced Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SUPABASE_JWKSas a bare JSON array[{...}], butparseJwksexpected{ keys: [...] }format{ keys: [...] }so both formats work