Skip to content

Conversation

@fenos
Copy link
Contributor

@fenos fenos commented Dec 2, 2022

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

  • etags were out of sync with S3 during copy and move operations
  • signed URL is using cache-control header instead of expires which means that the CDN cache doesn't honor the JWT expiry date

What is the new behavior?

  • etags are now in sync with s3 during copy and move operations
  • signed URL now returns the expires header with the date set as the JWT expiry date

@fenos fenos force-pushed the fix/consitent-etags-and-sign-expiry branch from 6fdf5e4 to 439f4a5 Compare December 2, 2022 15:34
@coveralls
Copy link

coveralls commented Dec 2, 2022

Pull Request Test Coverage Report for Build 3603007044

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 48 of 50 (96.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 86.672%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/renderer/renderer.ts 31 33 93.94%
Totals Coverage Status
Change from base Build 3599751846: 0.06%
Covered Lines: 4866
Relevant Lines: 5592

💛 - Coveralls

@fenos fenos merged commit 5380325 into master Dec 5, 2022
@fenos fenos deleted the fix/consitent-etags-and-sign-expiry branch December 5, 2022 08:11
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

🎉 This PR is included in version 0.25.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants