This repository was archived by the owner on Oct 9, 2025. It is now read-only.
feat: Added a method to get public URL of an object #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshukertjr
changed the title
|
Was going to add tests, but did not find any object related tests, so left it for now. If someone could direct me, that will be great! |
dshukertjr
commented
May 31, 2021
inian
reviewed
May 31, 2021
|
This is amazing Tyler! I was planning on adding this, but really appreciate the contribution :) I will leave this open since old projects need to be updated to storage-api 0.3.0 for this to work for them. This will be done in a day or two. |
|
Sounds fantastic @inian ! |
dshukertjr
changed the title
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Introducing a new feature to add a method to easily retrieve public URLs of object uploaded to storage.
Related PR on storage-api
supabase/storage#19
What is the current behavior?
There is not an easy way of getting a public URL of an object.
What is the new behavior?
There will be a method where you can just pass the bucket and the path, and it will return full URL of the object.
Additional context
I don't know if we need a method like this when all it is doing is just concatenating Supabase URL, bucket name, and path with '/object/public' in the middle, but personally I would appreciate if the SDK could handle the concatenation.
Also, I was not sure if implementing something like this has been discussed internally, so if there is already a plan for it, and is different from the code that I wrote, please feel free to just close this PR.
Otherwise, any feedback is greatly appreciated!