Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

@dishwad
Copy link
Contributor

@dishwad dishwad commented Jun 8, 2023

Addresses issues:
#104

@dishwad dishwad marked this pull request as draft June 8, 2023 02:18
@dishwad dishwad marked this pull request as ready for review June 8, 2023 02:20
@dishwad dishwad requested a review from anand2312 June 8, 2023 14:50
@anand2312 anand2312 linked an issue Jun 9, 2023 that may be closed by this pull request
Copy link
Contributor

@anand2312 anand2312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anand2312
Copy link
Contributor

@dishwad run poetry run pre-commit install locally to install pre-commit hooks so that black is automatically run on every commit - that's what seems to be failing in CI right now 😄

Also you don't have to manually write the code for the sync client, we generate that using unasync - poetry run unasync storage3 and poetry run unasync tests generates sync code for us 😅 I should probably document that somewhere

@anand2312 anand2312 requested a review from J0 June 9, 2023 04:16
@dishwad
Copy link
Contributor Author

dishwad commented Jun 9, 2023

Ok I removed the code for the sync client and the sync test. I ran poetry run pre-commit install locally and black is passing for me locally.

@J0
Copy link
Contributor

J0 commented Jun 10, 2023

Hm might be the case that poetry version of black doesn't tally with the pre commit hook config. Former is 23.3.0 and latter is 23.1.0. Let me bump - might need to trouble you to rerun

@codecov-commenter

This comment was marked as off-topic.

@anand2312
Copy link
Contributor

anand2312 commented Jun 10, 2023

Odd - the pre-commit hook for black was reformatting tests/_async/test_client.py on CI but ignoring it locally. Running black manually on that file seems to have fixed it.
Thanks for the PR @dishwad!

@anand2312 anand2312 merged commit 2c5e2fc into supabase:main Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add create_signed_urls function to return multiple signed URLs

4 participants