Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

fix: make download key optional #153

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix: make download key optional #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbf8213
fix: make download key optional
anand2312 Sep 28, 2023
fc93662
chore: run unasync
anand2312 Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion storage3/_async/file_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ async def create_signed_urls(
"""
json = {"paths": paths, "expiresIn": str(expires_in)}
if options.get("download"):
json.update({"download": options["download"]})
json.update({"download": options.get("download")})

response = await self._request(
"POST",
Expand Down
2 changes: 1 addition & 1 deletion storage3/_sync/file_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def create_signed_urls(
"""
json = {"paths": paths, "expiresIn": str(expires_in)}
if options.get("download"):
json.update({"download": options["download"]})
json.update({"download": options.get("download")})

response = self._request(
"POST",
Expand Down
2 changes: 1 addition & 1 deletion storage3/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class URLOptions(TypedDict, total=False):
transform: TransformOptions


class CreateSignedURLsOptions(TypedDict):
class CreateSignedURLsOptions(TypedDict, total=False):
download: Union[str, bool]


Expand Down