Skip to content

Conversation

@fenos
Copy link
Contributor

@fenos fenos commented Jan 13, 2025

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

Restructuring imports to prevent import cycles.
package: @internal/database/migrations is now a stand-alone package.

  • Moved tenant migrations logic outside of the tenants.ts file

@coveralls
Copy link

coveralls commented Jan 13, 2025

Pull Request Test Coverage Report for Build 12747958651

Details

  • 48 of 119 (40.34%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 78.003%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/routes/admin/tenants.ts 4 7 57.14%
src/storage/events/webhook.ts 1 7 14.29%
src/internal/database/migrations/migrate.ts 20 82 24.39%
Totals Coverage Status
Change from base Build 12744588100: -0.03%
Covered Lines: 14245
Relevant Lines: 18111

💛 - Coveralls

@fenos fenos force-pushed the fix/cleanup-imports branch from 11477bb to 360548c Compare January 13, 2025 13:11
@fenos fenos merged commit efeb853 into master Jan 13, 2025
1 check passed
@fenos fenos deleted the fix/cleanup-imports branch January 13, 2025 13:42
@github-actions
Copy link

🎉 This PR is included in version 1.16.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants