feat(oauth): add updateClient method to admin OAuth API #1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add UpdateOAuthClientParams class for updating OAuth clients - Implement updateClient method in GoTrueAdminOAuthApi - Add pagination fields (nextPage, lastPage, total) to OAuthClientListResponse - Add tests for updateClient functionality and UUID validation This completes the Flutter SDK implementation to match the JavaScript SDK's GoTrueAdminApi OAuth methods, providing full parity with listClients, createClient, getClient, updateClient, deleteClient, and regenerateClientSecret.
mandarini
approved these changes
Nov 10, 2025
Simplify the updateClient test by removing optional parameter assertions and update GoTrue test container to v2.182.1 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Pull Request Test Coverage Report for Build 19294327110Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the Flutter SDK implementation of Admin OAuth methods to match the JavaScript SDK's
GoTrueAdminApiOAuth functionality.Changes
UpdateOAuthClientParamsclass for updating OAuth clientsupdateClientmethod inGoTrueAdminOAuthApinextPage,lastPage,total) toOAuthClientListResponseupdateClientfunctionality and UUID validationComparison with JS SDK
listClientscreateClientgetClientupdateClientdeleteClientregenerateClientSecretTesting
updateClientfunctionalityupdateClientNotes
The pagination fields (
nextPage,lastPage,total) are included in the response type to match the JS SDK interface. Full header-based pagination parsing would require changes to the fetch implementation and can be addressed in a future PR if needed.Related