Phone Number Not Stored During Signup When Email Confirmation Enabled

[chatdmc]

When both email and phone number are provided during user signup, and:

• Email confirmation is enabled
• Phone confirmation is disabled

The phone number is incorrectly stored as null in the database. However, the same phone number can be successfully stored when using the updateUser method.

Signup function

value of formData.adminMobile: +919996381211

Update user function

value of formData.adminMobile: +919996381211

But in case of update it got updated in auth.users table

Steps to Reproduce

1. Configure system with:
   • Email confirmation: enabled
   • Phone confirmation: disabled
2. Attempt to create a new user with both email and phone number
3. Check the stored user data in the database
4. Attempt to update the same user with a phone number using updateUser

Current Behavior

• During signup: Phone number is stored as null
• During update: Phone number is stored correctly

Expected Behavior

Phone number should be stored correctly in both scenarios:

• During initial user signup
• During user update

Labels

• bug
• authentication
• user-management

[AmanVerma2202]

Can I work on this?

[Hallidayo]

Hi @AmanVerma2202 - Of course, Feel free to open a pr, thanks!

[alexmotoc]

I tried running supabase-auth locally and sending POST requests to the /signUp endpoint using the config shown above and I wasn't able to replicate the issues - I could see the phone being saved correctly in the database.

I believe the issue is coming from the auth-js client that is not sending the phone on the request if the email is present in the credentials:

https://github.com/supabase/auth-js/blob/master/src/GoTrueClient.ts#L457-L464

Edit: Had some time to take another look at this. I realised I had made a mistake with the first statement and incorrectly sent requests the /admin/users instead of signUp, my bad!

That being said, considering a user cannot provide both an email and a phone when signing up (resulting in a Bad Request), it might be a good idea to improve the types for this method.

From a DX point of view I think it would be good to throw a compile error if the user is trying to provide both fields:

signUp({ email: 'test@test.com', phone: '+1234', password: '123456' }) // TypeError
signUp({ email: 'test@test.com', password: '123456' }) // Fine
signUp({ phone: '+1234', password: '123456' }) // Fine

[Hallidayo]

Hi all, I've moved this over to the auth-js repo.

[mandarini]

Duplicate of #1305.

Please keep all conversation in #1305