Skip to content

Conversation

@mandarini
Copy link
Contributor

@mandarini mandarini commented Oct 23, 2025

Improve integration testing.

Cleanup package-lock.json file from old dependencies, and fix issues that were ignored due to old lock file.

Added --unstable-detect-cjs flag to the Deno test scripts to handle module format compatibility issues with our locally published packages. Our packages provide both CommonJS and ESM builds, and when Deno imports from npm (including our local registry), it sometimes picks the CommonJS version instead of ESM. This flag enables Deno to automatically detect and properly handle CommonJS modules, allowing our integration tests to run successfully. While marked as "unstable," this flag is safe for our testing purposes - it only affects how Deno interprets module formats during import resolution, not the actual test execution or coverage. The tests pass and validate the same functionality with or without it; the flag just ensures Deno can properly load our dual-format packages.

@mandarini mandarini changed the title Chore/cleanup lock chore(repo): cleanup package-lock.json and bun.lock Oct 23, 2025
@coveralls
Copy link

coveralls commented Oct 23, 2025

Coverage Status

coverage: 95.455% (-0.5%) from 95.986%
when pulling 863ab13 on chore/cleanup-lock
into 88f9aa8 on master.

@mandarini mandarini marked this pull request as ready for review October 23, 2025 14:46
@mandarini mandarini requested review from a team as code owners October 23, 2025 14:46
@mandarini mandarini self-assigned this Oct 23, 2025
grdsdev
grdsdev previously approved these changes Oct 23, 2025
@mandarini mandarini changed the title chore(repo): cleanup package-lock.json and bun.lock test(repo): cleanup package-lock.json and bun.lock Oct 23, 2025
@mandarini mandarini enabled auto-merge (squash) October 23, 2025 14:56
@mandarini mandarini requested a review from grdsdev October 23, 2025 14:56
@mandarini mandarini disabled auto-merge October 23, 2025 15:02
@mandarini mandarini changed the title test(repo): cleanup package-lock.json and bun.lock fix(repo): cleanup package-lock.json and bun.lock Oct 23, 2025
@mandarini mandarini enabled auto-merge (squash) October 23, 2025 15:13
@mandarini mandarini merged commit d70d3e0 into master Oct 23, 2025
24 checks passed
@mandarini mandarini deleted the chore/cleanup-lock branch October 23, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants