fix(realtime): account for null refs when encoding messages #1862
+114
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref and join_ref can be null/undefined in certain scenarios like when publishing heartbeaats. Currently using JSON to send heartbeats but in the future this can be changed and we want to be ready
grdsdev
approved these changes
Nov 17, 2025
Member
Author
|
Thanks, team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
ref and join_ref can be null/undefined in certain scenarios like when publishing heartbeats.
Currently using JSON to send heartbeats so not an actual issue but in the future this can be changed and we want to be ready.
What changed?
Serializer handles null/undefined for
join_refandrefWhy was this change needed?
The
Msgtype is now fixed with optionaljoin_refandref. Heartbeats for example don't send ajoin_refas they don't have a specific channel to refer to.📸 Screenshots/Examples
🔄 Breaking changes
📋 Checklist
<type>(<scope>): <description>npx nx formatto ensure consistent code formatting📝 Additional notes