Storage HTTPx client doesn't have a base_url

[weshoke]

Bug report

• I confirm this is a bug with Supabase, not with my own application.
• [ x ] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

When using the 2.22.3 Python client, I'm finding the create_signed_upload_url doesn't have a base_url.
I traced it to when the storage object is created from the client, a base_url isn't being passed in to where the HTTP client is created. If options.http_client is None, which it is in my case,

self.session = http_client or AsyncClient(
            headers=headers,
            timeout=self.timeout,
            proxy=proxy,
            verify=self.verify,
            follow_redirects=True,
            http2=True,
        )

This code will create an async client and it's not passing in base_url, so it's set as the empty string. This leaves the pre-signed URLs having no protocol/domain, etc.

To Reproduce

I'm running this in a local dev environment

This is my hack to get it to work:

async def generate_presigned_url(
    storage_client: AsyncClient,
    bucket: str,
    storage_path: str,
) -> str:
    """Generate presigned URL for upload to Supabase storage."""
    bucket_client = storage_client.storage.from_(bucket)
    # For some reason, the base URL is not set correctly
    # NOTE: Supabase bug?
    if bucket_client._client.base_url == "":
        bucket_client._client.base_url = f"{settings.supabase_url}/storage/v1/"
    result = await storage_client.storage.from_(bucket).create_signed_upload_url(storage_path)

    return result["signed_url"]

Expected behavior

The returned URL should have a protocol and domain.

Screenshots

If applicable, add screenshots to help explain your problem.

System information

OSX, Python client, 2.22.3

Additional context

Add any other context about the problem here.

[peekknuf]

Hello!

Great catch. It seems to be a small remnant of this rework: #1249

I've run some test scripts, and it looks like updating src/storage/src/storage3/_sync/file_api.py#L114
From: str(self._client.base_url) + cast(str, data["url"]).lstrip("/")
to: str(self._base_url) + cast(str, data["url"]).lstrip("/")
could do the trick

Cheers!

P.S. Posting directly on supabase/supabase-py would’ve probably gotten you a faster reply.

[aantti]

@o-santi

[o-santi]

Thank you for tagging me in, I'll transfer it to the supabase-py repo.

[o-santi]

I don't understand how this is happening, and your example is not a reproduction. In create_signed_upload_url, the base_url (from self._client.base_url) is correctly appended behind the URL before returning the object.

full_url: urllib.parse.ParseResult = urllib.parse.urlparse(
    str(self._client.base_url) + cast(str, data["url"]).lstrip("/")
)

self._client.base_url is created when initializing the AsyncStorageClient instance, and url is an obligatory argument for that. Unless you're passing in url as "", I don't see how this is happening.

@weshoke please provide a proper reproduction, including how the client is initialized and how it is called later on.

NOTE: We explicitly save the url instead of setting it on the http_client because sharing a mutable variable leads to all kinds of issues (relevant #1244).

[weshoke]

import asyncio

from mylib.core.settings import settings
from supabase import create_async_client


async def test():
    print(settings.supabase_url)
    client = await create_async_client(
        supabase_url=settings.supabase_url,
        supabase_key=settings.supabase_service_role_key,
    )
    bucket_client = client.storage.from_(settings.storage_bucket)
    print(f"{bucket_client._client.base_url=}")


if __name__ == "__main__":
    asyncio.run(test())

Output:

http://127.0.0.1:54321
bucket_client._client.base_url=URL('')

[o-santi]

I think I understand the issue now. The _client.base_url is not being set exactly because of the aforementioned issue, and instead we reference bucket_client._base_url, set in AsyncStorageClient.__init__:

import asyncio

from supabase import create_async_client


async def test():
    client = await create_async_client(
        supabase_url="http://127.0.0.1:54321",
        supabase_key="eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJyb2xlIjoiYW5vbiIsImlhdCI6MTYzNTAwODQ4NywiZXhwIjoxOTUwNTg0NDg3fQ.l8IgkO7TQokGSc9OJoobXIVXsOXkilXl4Ak6SCX5qI8",
    )
    bucket_client = client.storage
    print(f"{bucket_client._client.base_url=}")
    print(f"{bucket_client._base_url=}")


if __name__ == "__main__":
    asyncio.run(test())

Output:

bucket_client._client.base_url=URL('')
bucket_client._base_url=URL('http://127.0.0.1:54321/storage/v1/')

While this is certainly a change, I don't think relying on the httpx client base url is a valid thing to do. Is this causing any errors in create_upload_signed_url?

[o-santi]

Oh wait, I see it now. We are reading the wrong variable. I'll fix it ASAP.

[o-santi]

Fixed v2.23.2.

@weshoke thank you for raising the issue. If you find anything else, please feel free to report it, preferably directly in this repository so that we can provide quicker feedback.