Skip to content

Conversation

@SaxonF
Copy link
Contributor

@SaxonF SaxonF commented Nov 25, 2024

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

Makes some improvements to the assistant

there’s a bit here where the “Thinking…” loading state goes away too early and I think the request has failed
Show Query” when hidden, “Hide Query” when shown
border accidentally too short
Passes the current table and schema as context if we have it
Added "suggestions" when editing a policy

@SaxonF SaxonF requested a review from a team as a code owner November 25, 2024 11:13
@vercel
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 11:05am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
design-system ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 11:05am
studio ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 11:05am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 11:05am
docs ⬜️ Skipped (Inspect) Nov 26, 2024 11:05am
zone-www-dot-com ⬜️ Skipped (Inspect) Nov 26, 2024 11:05am

@supabase
Copy link

supabase bot commented Nov 25, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

Copy link
Member

@joshenlim joshenlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested on preview

  • Suggestions when editing policy with assistant
  • schema and table gets passed to generate-v3 when querying on table editor
  • table is not passed if on a page that also has ID param (e.g sql editor)
  • Current SQL snippet gets passed as context when opening assistant in SQL editor

@joshenlim joshenlim merged commit 72910fc into master Nov 26, 2024
14 checks passed
@joshenlim joshenlim deleted the feat/assistant-additions branch November 26, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants