chore: add usercentrics for consent management #35384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
staaldraad
reviewed
Apr 30, 2025
| ? 'https://frontend-assets.supabase.green' | ||
| : 'https://frontend-assets.supabase.com' | ||
|
|
||
| const USERCENTRICS_URLS = 'https://*.usercentrics.eu' |
Member
There was a problem hiding this comment.
staaldraad
approved these changes
Apr 30, 2025
Contributor
|
some tests: no VPN go www
docs VPN and no VPN same functionality as www
studio VPN does not show banner and can’t change privacy settings Fixes we need:
|
pamelachia
reviewed
Apr 30, 2025
apps/studio/components/interfaces/Account/Preferences/AnalyticsSettings.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Tested docs and www and studio
Should be last fixes needed:
|
Contributor
|
ok the first pageview works now and tested the referrer shows t.co when i went from twitter to www homepage for in and out of EU. When in EU, I clicked to another page, clicked accept banner, then another page, and the new sent event still showed referrer as t.co I get 500 errors for UI lib preview. Code looks right though. If it looks good let's merge this ASAP so we can get some early data to roll in over the weekend when our traffic is low. |
pamelachia
approved these changes
May 2, 2025
jordienr
approved these changes
May 2, 2025
Member
jordienr
left a comment
jordienr
left a comment
There was a problem hiding this comment.
tested in docs and studio preview and looks good. Brave seems to block everything anyway but chrome sends the events after accepting the toast.
| // Although this is "technically" breaking the rules of hooks | ||
| // IS_PLATFORM never changes within a session, so this won't cause any issues | ||
| // eslint-disable-next-line react-hooks/rules-of-hooks | ||
| const { hasAcceptedConsent } = IS_PLATFORM ? useConsentToast() : { hasAcceptedConsent: true } |
Member
There was a problem hiding this comment.
you could use an { enabled: bool } argument in the hook to enable/disable it conditionally without breaking the hook law
useConsentToast({ enabled: IS_PLATFORM })
seanoliver
added a commit
that referenced
this pull request
Nov 7, 2025
Fixes bug where App Router pages (docs, www/blog) only tracked the initial page load but not subsequent navigations. The issue was introduced in PR #35384 which inverted the logic for the App Router telemetry tracking. The condition checked `!hasSentInitialPageTelemetryRef.current` which prevented tracking after the initial page view was sent. Changed to match Pages Router behavior: wait until initial page view is sent, then track all subsequent pathname changes. Before: Only first page view tracked After: All page navigations tracked (like Pages Router) Affects: docs app, www app (blog pages)
seanoliver
added a commit
that referenced
this pull request
Nov 7, 2025
Fixes bug where App Router pages (docs, www/blog) only tracked the initial page load but not subsequent navigations. The issue was introduced in PR #35384 which inverted the logic for App Router telemetry tracking. The condition used a boolean flag that prevented tracking after the initial page view. The root cause: useEffect with [appPathname] dependency fires both on initial mount AND on pathname changes. The flag-based approach couldn't differentiate between these two cases. Solution: Track the previous pathname to detect actual changes. - Initial mount: previousAppPathnameRef is null, skip (initial effect handles it) - Navigation: previousAppPathnameRef !== appPathname, send telemetry Before: Only first page view tracked After: All page navigations tracked (like Pages Router) Affects: docs app, www app (blog pages)
seanoliver
added a commit
that referenced
this pull request
Nov 7, 2025
Fixes bug where App Router pages (docs, www/blog) only tracked the initial page load but not subsequent navigations. The issue was introduced in PR #35384 which inverted the logic for App Router telemetry tracking. The condition used a boolean flag that prevented tracking after the initial page view. The root cause: useEffect with [appPathname] dependency fires both on initial mount AND on pathname changes. The flag-based approach couldn't differentiate between these two cases. Solution: Track the previous pathname to detect actual changes. - Initial mount: previousAppPathnameRef is null, skip (initial effect handles it) - Navigation: previousAppPathnameRef !== appPathname, send telemetry Before: Only first page view tracked After: All page navigations tracked (like Pages Router) Affects: docs app, www app (blog pages)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses FE-1601, FE-1602 (indirectly) and FE-1603 (directly).
Testing
Non-EU:
EU:
Open docs/www/studio and ensure:
You can use a VPN to swap into Europe. Make sure to clear local storage in between changes.