Mitigate race condition when fetching folder contents storage #36363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves FE-1677
Context
We've got a report internally that the storage explorer occasionally shows an error "Failed to retrieve folder contents from ...: bucketId is required". This error stems from
fetchFolderContentsin the storage explorer store, andfetchFolderContentsuses the internal statestate.selectedBucket.idto call the request to fetch the contentsStorageExplorer.tsxhas a a couple ofuseEffects - of which two of them have a tendency for a race condition, specifically:useEffectforopenBucketwithbucketin the dependency arrayuseEffectforfetchFolderContentswithitemSearchStringin the arrayBecause of this - there's technically a chance of
fetchFolderContentsbeing triggered beforeopenBucketwas called, in which casestate.selectedBucketwouldn't have been set just yet, and hence cause the errorChanges involved
fetchFolderContentsnow accepts the an additional parameterbucketIdrather than relying on the internal state ofselectedBucketuseEffectforfetchFolderContentsin the if block forSTORAGE_VIEWS.COLUMNS, conditionally callfetchFolderContentsifopenedFolders.lengthis 0useSelectedBucketso that the currently selected bucket can be accessed easilyTo test