Skip to content

Conversation

@staaldraad
Copy link
Member

What kind of change does this PR introduce?

Feature

What is the current behavior?

When MFA is enforced on an organization and the user does not have MFA enabled, the organization is not visible in the dashboard.

What is the new behavior?

Disables organization selection if the org requires MFA but the user does not have MFA enabled.

Add badges / hints to show that user has access to an Organization but access is disabled because of MFA access requirement

Additional context

MFA enforcement is still behind a feature flag

User has MFA enabled, can select all orgs and has a badge to know about enforcement:

Screenshot 2025-06-16 at 13 16 12

User does not have MFA enabled, org is visible but not selectable:
Screenshot 2025-06-16 at 13 17 25
Screenshot 2025-06-16 at 13 17 42

Disables organization selection if the org requires MFA but the user
does not have MFA enabled.
Add badges / hints to show that user has access to an Organization but
access is disabled because of MFA access requirement
@staaldraad staaldraad requested a review from a team as a code owner June 16, 2025 11:21
@vercel
Copy link

vercel bot commented Jun 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2025 10:39am
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2025 10:39am
studio-self-hosted ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2025 10:39am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2025 10:39am
ui-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2025 10:39am
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2025 10:39am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cms ⬜️ Ignored (Inspect) Jun 17, 2025 10:39am
studio ⬜️ Ignored (Inspect) Visit Preview Jun 17, 2025 10:39am

@supabase
Copy link

supabase bot commented Jun 16, 2025

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coveralls
Copy link

coveralls commented Jun 16, 2025

Coverage Status

coverage: 82.967%. remained the same
when pulling 3e35fdc on etienne/sec-275-ui-element-for-warning-about-users-without-mfa
into 7c678b9 on master.

@joshenlim joshenlim requested a review from a team as a code owner June 17, 2025 10:07
@joshenlim
Copy link
Member

Pushing up some UI tweaks

  • Reduced UI indication for MFA enabled to just an icon and tooltip
    image

  • Allow switching to the organization that has MFA enforced but user hasn't set up MFA + show an indicator to set up MFA prior to accessing organization
    image

  • Add redirect logic, when entering a page that's scoped to an organization (includes project pages), if org has MFA enabled but user does not have MFA set up, redirect back to org home page

  • (Unrelated) Fix OrganizationCard linking to /new/[slug], support taking href as a param instead

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Tested on preview

@staaldraad staaldraad merged commit aeaf831 into master Jun 20, 2025
20 of 21 checks passed
@staaldraad staaldraad deleted the etienne/sec-275-ui-element-for-warning-about-users-without-mfa branch June 20, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants