-
-
Couldn't load subscription status.
- Fork 10.3k
realtime: improve protocol docs; move settings to a guides #37280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
3c87730 to
3c6770d
Compare
3c6770d to
9a895f4
Compare
| | Event Type | Description | Client Sent | Server Sent | Requires Ref | | ||
| |------------|-------------|--------------|-------------|--------------| | ||
| | `phx_join` | Initial message to join a channel and configure features | ✅ | ⛔ | ✅ | | ||
| | `phx_close` | Message from server to signal channel closed | ✅ | ⛔ | ⛔ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one says "message from server" but "client sent"-only, is that intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for catching it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you refer to this as --dark in the img src?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes forgot to push change 😓
Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
|
made the fixes, thank you @charislam 🙏 |
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
improve protocol docs; move settings to a guides