-
-
Couldn't load subscription status.
- Fork 10.3k
Update Angular tutorial to use v20 #37380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Chris Chinchilla <christopher.ward@supabase.io>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This reverts commit c45ea9d.
| You can pull the database schema down to your local project by running the `db pull` command. Read the [local development docs](/docs/guides/cli/local-development#link-your-project) for detailed instructions. | ||
|
|
||
| </Admonition> | ||
| {/* TODO: discuss */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are certain places where it feels like other content should be part of the admonition, but maybe there's a reason they aren't.
For example, here, as you scroll down, it looks like the code has nothing to do with the admonition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm yeah I agree, maybe we should take the admonition out if it's not necessary for this tutorial?
| You can use the [Angular CLI](https://angular.io/cli) to initialize | ||
| an app called `supabase-angular`: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to make the command have a s few user questions as possible.
| </$CodeTabs> | ||
|
|
||
| Optionally, update [src/styles.css](https://raw.githubusercontent.com/supabase/supabase/master/examples/user-management/angular-user-management/src/styles.css) to style the app. | ||
| Optionally, update `src/styles.css` [with the following styles](https://raw.githubusercontent.com/supabase/supabase/master/examples/user-management/angular-user-management/src/styles.css) to style the app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that with the original, it was fairly easy to end up with no CSS and miss this step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments here and there. Otherwise, looks good to me! :D Should we add that this is for Angular 20+?
apps/docs/content/guides/getting-started/tutorials/with-angular.mdx
Outdated
Show resolved
Hide resolved
examples/user-management/angular-user-management/tsconfig.spec.json
Outdated
Show resolved
Hide resolved
The original issue cited 19, but that was a while ago. Are there any changes here specifically for 20? And how old/adopted is 20? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for figuring this one out 🔥 Switching out the code samples is my only recommendation, otherwise it's good to merge!
| You can pull the database schema down to your local project by running the `db pull` command. Read the [local development docs](/docs/guides/cli/local-development#link-your-project) for detailed instructions. | ||
|
|
||
| </Admonition> | ||
| {/* TODO: discuss */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm yeah I agree, maybe we should take the admonition out if it's not necessary for this tutorial?
| <$CodeTabs> | ||
|
|
||
| ```ts name=src/app/auth/auth.component.ts | ||
| ```ts name=src/app/auth/auth.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should take the opportunity to convert all these to embedded code samples. This will make testing way easier in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charislam Yes! 💯 I made a note about this myself :) A broader task maybe
|
@charislam Do you mean change the example code? To embeddables? There’s a lot of docs that could so with that, so I wonder if it's better a separate task(s)… 🤔 |
* Add Chris Ward to humans Signed-off-by: Chris Chinchilla <christopher.ward@supabase.io> * Update Angular tutorial for Angular 20 * Update Angular doc * Revert "Add Chris Ward to humans" This reverts commit c45ea9d. * Update tsconfig * Add note about CLI defaults * Prettier fix --------- Signed-off-by: Chris Chinchilla <christopher.ward@supabase.io> Co-authored-by: Chris Chinchilla <christopher.ward@supabase.io>
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
Docs update.
What is the current behavior?
closes ##32652
What is the new behavior?
Tutorial and example code now works with Angular 20.