Skip to content

Conversation

@joshenlim
Copy link
Member

Fixes FE-1340

RE Cron history page, if the cron job is using an edge function + the edge function is from the project
Adds a link to the respective edge function's logs page

image

@joshenlim joshenlim requested a review from a team as a code owner July 29, 2025 10:50
@vercel
Copy link

vercel bot commented Jul 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 6:59am
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 6:59am
studio-self-hosted ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 6:59am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 6:59am
ui-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 6:59am
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 6:59am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cms ⬜️ Ignored (Inspect) Aug 5, 2025 6:59am
studio ⬜️ Ignored (Inspect) Aug 5, 2025 6:59am

@supabase
Copy link

supabase bot commented Jul 29, 2025

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coveralls
Copy link

coveralls commented Jul 29, 2025

Coverage Status

coverage: 82.964%. remained the same
when pulling ec10c39 on chore/add-link-to-edge-function-logs-in-cron-if-using-function
into 8b18592 on master.

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Tested on preview

const cronJobRuns = useMemo(() => data?.pages.flatMap((p) => p) || [], [data?.pages])
useEffect(() => {
// Refetch only the first page
const timerId = setInterval(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could this be moved to the refetchInternal function of the query?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opting to remove this instead actually - and letting staleTime from the query handle the refetching logic
cause this might be confusing if the user's not on the first page after the interval duration

@joshenlim joshenlim merged commit 81dda5b into master Aug 5, 2025
19 of 20 checks passed
@joshenlim joshenlim deleted the chore/add-link-to-edge-function-logs-in-cron-if-using-function branch August 5, 2025 07:02
PLyn pushed a commit that referenced this pull request Aug 25, 2025
… function (#37531)

* Add link to edge function logs for cron history if cron is using edge function

* Patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants