Button to add preventDefault onClick if disabled #37784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
joshenlim
changed the title
joshenlim
commented
Aug 8, 2025
| import { cloneElement, forwardRef, isValidElement } from 'react' | ||
| import { SIZE_VARIANTS, SIZE_VARIANTS_DEFAULT } from '../../lib/constants' | ||
| import { cn } from '../../lib/utils/cn' | ||
| import { IconContext } from '../Icon/IconContext' |
SaxonF
approved these changes
Aug 12, 2025
joshenlim
deleted the
chore/buttontooltip-add-prevent-default-onclick-if-disabled
branch
PLyn
pushed a commit
that referenced
this pull request
Aug 25, 2025
* ButtonTooltp to add preventDefault onClick if disabled * Update base component Button instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If Button is used with a link element (e.g
<Link>or<a>), users will still be redirected to the link upon clicking the button even if the button is disabled. The changes here should address that by preventing the redirect if the button is disabledAlthough do let me know if I might be overlooking something here! 🙏