ui consistency issues #37823
Merged
ui consistency issues #37823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
SaxonF
had a problem deploying
to
Studio E2E Tests
GitHub Actions
Error
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
SaxonF
had a problem deploying
to
Studio E2E Tests
GitHub Actions
Error
SaxonF
had a problem deploying
to
Studio E2E Tests
GitHub Actions
Error
joshenlim
reviewed
Aug 12, 2025
apps/studio/components/interfaces/Storage/StoragePolicies/StoragePolicies.tsx
Outdated
Show resolved
Hide resolved
joshenlim
reviewed
Aug 12, 2025
apps/studio/components/interfaces/Storage/StorageSettings/S3Connection.tsx
Show resolved
Hide resolved
joshenlim
had a problem deploying
to
Studio E2E Tests
GitHub Actions
Error
|
We should probably also add deprecate comments to the existing |
joshenlim
had a problem deploying
to
Studio E2E Tests
GitHub Actions
Error
joshenlim
had a problem deploying
to
Studio E2E Tests
GitHub Actions
Failure
joshenlim
approved these changes
Aug 12, 2025
dnywh
reviewed
Aug 13, 2025
| return ( | ||
| <ScaffoldContainer size="large" className="pt-6"> | ||
| {IS_PLATFORM ? <EdgeFunctionSecrets /> : <FunctionsSecretsEmptyStateLocal />} | ||
| <ScaffoldContainer size="large"> |
There was a problem hiding this comment.
I assume this size="large" is intentionally different to other (skinnier) settings pages, like Storage Settings and Storage Policies, given that this one deals with tabular data.
PLyn
pushed a commit
that referenced
this pull request
Aug 25, 2025
* ui consistency issues * storage policies * copy * Fix storage policies y gap * Small fixes * Add deprecated comments * Use Card component for S3 settings --------- Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some UI consistency work involving: