Skip to content

Conversation

@alaister
Copy link
Member

@alaister alaister commented Sep 1, 2025

Adds custom attributes to the ConfigCat user. At this stage just cloud_provider

@alaister alaister requested a review from a team as a code owner September 1, 2025 10:00
@supabase
Copy link

supabase bot commented Sep 1, 2025

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@vercel
Copy link

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
design-system Ready Ready Preview Comment Sep 1, 2025 10:09am
docs Ready Ready Preview Comment Sep 1, 2025 10:09am
studio-self-hosted Ready Ready Preview Comment Sep 1, 2025 10:09am
studio-staging Ready Ready Preview Comment Sep 1, 2025 10:09am
ui-library Ready Ready Preview Comment Sep 1, 2025 10:09am
zone-www-dot-com Ready Ready Preview Comment Sep 1, 2025 10:09am
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cms Ignored Ignored Sep 1, 2025 10:09am
studio Ignored Ignored Sep 1, 2025 10:09am

@sentry-io
Copy link

sentry-io bot commented Sep 1, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packages/common/configcat.ts

Function Unhandled Issue
getClient TypeError: Failed to fetch (configcat.supabase.green) /sign-i...
Event Count: 1 Affected Users: 0
getClient TypeError: Load failed (configcat.supabase.green) /dashboard/org/qfdmajxkgdjcfwilhqc...
Event Count: 1 Affected Users: 0

Did you find this useful? React with a 👍 or 👎

@coveralls
Copy link

Coverage Status

coverage: 70.67%. remained the same
when pulling 4be35e9 on chore/configcat-custom-attributes
into 367cf17 on master.

Copy link
Member

@joshenlim joshenlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise LGTM! Verified on staging preview minimally that existing feature flags are still working

@alaister alaister merged commit d449653 into master Sep 1, 2025
20 of 21 checks passed
@alaister alaister deleted the chore/configcat-custom-attributes branch September 1, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants