Skip to content

Conversation

@kemaldotearth
Copy link
Contributor

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

This introduces a lot of nit picky fixes and improvements to the org Usage area. The changes will aim to be small in nature and give us a platform to build up and improve this area.

@vercel
Copy link

vercel bot commented Sep 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
design-system Ready Ready Preview Comment Sep 8, 2025 10:01am
docs Ready Ready Preview Comment Sep 8, 2025 10:01am
studio-self-hosted Ready Ready Preview Comment Sep 8, 2025 10:01am
studio-staging Ready Ready Preview Comment Sep 8, 2025 10:01am
ui-library Ready Ready Preview Comment Sep 8, 2025 10:01am
zone-www-dot-com Ready Ready Preview Comment Sep 8, 2025 10:01am
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cms Ignored Ignored Sep 8, 2025 10:01am
studio Ignored Ignored Sep 8, 2025 10:01am

@supabase
Copy link

supabase bot commented Sep 3, 2025

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coveralls
Copy link

coveralls commented Sep 3, 2025

Coverage Status

coverage: 70.662%. remained the same
when pulling 7188b03 on feat/usage-area-brushup
into fa4510d on master.

otherwise non-anchored metrics get #undefined Link and unnecessary pointer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guessing this one's just updating the ternary? no other visual changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dnywh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes I made to this BillingMetric component in this PR:

  • dd52f8d: minor type size and icon colour tweak
  • 4aff4a5: moved where the wrapping Link was positioned to avoid /#undefined when it isn’t applicable (i.e. that metric.anchor ternary update)

The setSelectedProjectRef was causing our rings not to show on the usage table.
@joshenlim
Copy link
Member

Just a feedback: with the removal of the divider, feels like the sections are a bit more disjointed imo

e.g MAU and MA-SSO users are meant to be under "Activity" but it now seems like only MAU is under "Activity" and MA-SSO users is a separate section
image

Copy link
Member

@joshenlim joshenlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM - checked on staging preview but JFYI i'm not able to test ComputeMetric.tsx as I don't seem to have that data on my staging organization

Non-blocking feedback RE the removal of the dividers for the SectionHeaders here

@kemaldotearth kemaldotearth merged commit a578708 into master Sep 8, 2025
19 of 20 checks passed
@kemaldotearth kemaldotearth deleted the feat/usage-area-brushup branch September 8, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants