Skip to content

Conversation

@joshenlim
Copy link
Member

@joshenlim joshenlim commented Sep 17, 2025

Context

Addresses various console warnings that show up in the developer tools when landing on the dashboard

  • Many many configcat warnings (shows up on prod too)
    image

    • Addressed by passing in a dummy user when calling getAllValuesAsync from configcat
  • motion is deprecated (shows up on local dev)
    image

    • As per the message, just swapping motion() to motion.create() in a couple of files
  • Failed to load chart sync settings from localStorage (shows up on local dev and build logs)
    image

    • This one's just because useChartHoverState is trying to access local storage before the browser is loaded, just added a check for window
  • Warning: Missing Description for DialogContent (shows up on local dev)
    image

    • Just shows up when opening the create branch modal, just needed to add aria-describedBy={undefined} in DialogContent (and we should do this whenever we're not rendering a <DialogDescription>)

To test

I'm mainly worried about the feature flags stuff, so just need to test if the flags are still working
A quick way to do so is to open the create branch modal to verify if the "include data" toggle is visible (that UI is behind a feature flag that's set to true)

@joshenlim joshenlim requested a review from a team as a code owner September 17, 2025 14:15
@vercel
Copy link

vercel bot commented Sep 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
design-system Ready Ready Preview Comment Sep 17, 2025 2:20pm
docs Ready Ready Preview Comment Sep 17, 2025 2:20pm
studio-self-hosted Ready Ready Preview Comment Sep 17, 2025 2:20pm
studio-staging Ready Ready Preview Comment Sep 17, 2025 2:20pm
ui-library Ready Ready Preview Comment Sep 17, 2025 2:20pm
zone-www-dot-com Ready Ready Preview Comment Sep 17, 2025 2:20pm
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cms Ignored Ignored Sep 17, 2025 2:20pm
studio Ignored Ignored Sep 17, 2025 2:20pm

@supabase
Copy link

supabase bot commented Sep 17, 2025

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

Copy link
Contributor

@charislam charislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked 'include data' flag and clicked around a bunch on the API keys page + tried the assistant in project layout

@joshenlim joshenlim merged commit 1160f89 into master Sep 17, 2025
21 of 24 checks passed
@joshenlim joshenlim deleted the chore/address-various-console-warnings branch September 17, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants