Skip to content

Conversation

@joshenlim
Copy link
Member

Context

We received an internal bug report that in the Auth Users UI, if you were to open the delete user confirmation modal through right clicking on the user - once the modal is closed (no matter cancelling or confirming the delete), nothing else in the dashboard is clickable.

Investigation

  • This is very very oddly specifically happening when Data Grid + Context Menu + Dialog (or any component that uses Shadcn Overlay, which includes Sheet) components are being used together (Using a Context Menu from Shadcn in a Data Grid to trigger a Dialog)
  • A pointer-events: none style is getting applied to the body element of the page when the modal gets closed, but that style isn't getting cleaned up - hence why the dashboard becomes unresponsive after
  • I can reproduce this not just in the Auth Users UI, but also in the Cron Jobs Table UI which has a similar set up of this 3 things
  • I cannot reproduce this in the SQL Editor UI (Side nav snippet list) as it doesn't use Data Grid (Only context menu and dialog)

Changes involved

  • Am opting to simplify and scoping down the fix by removing the pointer-events style on the body if it exists when closing the confirmation modal for just the Auth Users DeleteUserModal + CreateCronJobSheet + DeleteCronJob, since its specifically only happening in these 3 areas
  • Table Editor is not affected because it's not using the ContextMenu from Shadcn

To test

  • Verify in Auth Users UI, right click user -> Delete user, close modal, can still click around in the dashboard
  • Verify in Cron UI, right click job -> Edit / Dlete job, close sheet / modal, can still click around in the dashboard

@joshenlim joshenlim requested a review from a team as a code owner September 18, 2025 07:31
@vercel
Copy link

vercel bot commented Sep 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
studio-self-hosted Ready Ready Preview Comment Sep 18, 2025 8:47am
studio-staging Ready Ready Preview Comment Sep 18, 2025 8:47am
6 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cms Ignored Ignored Sep 18, 2025 8:47am
studio Ignored Ignored Sep 18, 2025 8:47am
design-system Skipped Skipped Sep 18, 2025 8:47am
docs Skipped Skipped Sep 18, 2025 8:47am
ui-library Skipped Skipped Sep 18, 2025 8:47am
zone-www-dot-com Skipped Skipped Sep 18, 2025 8:47am

@supabase
Copy link

supabase bot commented Sep 18, 2025

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coveralls
Copy link

coveralls commented Sep 18, 2025

Coverage Status

coverage: 70.533% (-0.2%) from 70.753%
when pulling 4fdc7b0 on chore/address-odd-bug-between-datagrid-contextmenu-and-overlay
into e1ec2d2 on master.

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Tested on preview

@joshenlim joshenlim merged commit 1b91f5a into master Sep 18, 2025
19 of 20 checks passed
@joshenlim joshenlim deleted the chore/address-odd-bug-between-datagrid-contextmenu-and-overlay branch September 18, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants