Skip to content

Conversation

@jordienr
Copy link
Member

@jordienr jordienr commented Sep 25, 2025

  • splits report into sections
  • makes sections deeplinkable
  • adds basic filtering by section
  • splits latency into different metrics/charts for readability
  • improves chart highlighting actions, actions can now be added per report, and action callback has more context (can check which chart the user is highlighting in the action callback)

To test

  • Use a project with some auth usage or mock some auth usage
  • Go to reports
  • metrics make sense (total users)
  • try filters
  • try deeplinking into a section
  • try highlighting a part of a chart and going to logs

@jordienr jordienr requested a review from a team as a code owner September 25, 2025 13:38
@vercel
Copy link

vercel bot commented Sep 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
design-system Ready Ready Preview Comment Oct 7, 2025 8:30pm
docs Ready Ready Preview Comment Oct 7, 2025 8:30pm
studio-self-hosted Ready Ready Preview Comment Oct 7, 2025 8:30pm
studio-staging Ready Ready Preview Comment Oct 7, 2025 8:30pm
ui-library Ready Ready Preview Comment Oct 7, 2025 8:30pm
zone-www-dot-com Ready Ready Preview Comment Oct 7, 2025 8:30pm
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cms Ignored Ignored Oct 7, 2025 8:30pm
studio Ignored Ignored Oct 7, 2025 8:30pm

@supabase
Copy link

supabase bot commented Sep 25, 2025

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Studio E2E Results

  • Total: 1
  • Passed: 1
  • Failed: 0
  • Skipped: 0
  • Timed out: 0
  • Interrupted: 0
  • Flaky: 0
  • Duration: 2.7s

Artifacts: https://github.com/supabase/supabase/actions/runs/18325185338

Last updated: Tuesday 7, October, 2025 20:39:28 (UTC)

@coveralls
Copy link

coveralls commented Sep 30, 2025

Coverage Status

coverage: 70.696% (+1.3%) from 69.37%
when pulling 7c9980f on jordi/auth-report-filters
into 32d1304 on master.

Copy link
Contributor

@charislam charislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is intended behavior, but I personally find it kinda odd that this shows 0 when nothing is hovered, I would expect it to show the cumulative number

CleanShot.2025-10-02.at.17.48.55.mp4

url += `&f={"product":{"auth":true},"status_code":{"error":true,"warning":true}}`
}

url += `&f={"product":{"auth":true}}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets added twice for the chartId?.includes('errors') case, is that intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed thx

)}
</div>
</>
<div className="w-full flex items-center gap-2 flex-wrap"></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this div intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we centralize these? Docs uses this file which we can move to a common package: https://github.com/supabase/supabase/blob/master/apps/docs/content/errorCodes/authErrorCodes.toml

And we adapt our webpack config to read it:

config.module.rules.push({
test: /\.toml$/,
type: 'json',
parser: {
parse: parseToml,
},
})

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to separate file, will make the changes to docs in a separate PR tho.

return whereClauses.length > 0 ? `WHERE ${whereClauses.join(' AND ')}` : ''
}

export const AUTH_ERROR_CODE_VALUES: string[] = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we derive this from a central definition of auth error codes? (See comment on auth.utils.ts)

}))

// Reuse the status-code pivot util by category name
const { transformCategoricalCountData } = await import(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this one have to be a dynamic import?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ai slop that i missed 🫠

@jordienr
Copy link
Member Author

jordienr commented Oct 7, 2025

I don't know if this is intended behavior, but I personally find it kinda odd that this shows 0 when nothing is hovered, I would expect it to show the cumulative number

Yep, that's planned but I'd like to ship it for all charts in a different PR, could get quite big.

@jordienr jordienr merged commit b5a638b into master Oct 9, 2025
19 of 20 checks passed
@jordienr jordienr deleted the jordi/auth-report-filters branch October 9, 2025 07:58
ivasilov pushed a commit that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants