Skip to content

swap error rate for success rate and add tests #39774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2025
Merged

swap error rate for success rate and add tests #39774

merged 3 commits into from
Oct 22, 2025

Conversation

@jordienr
Copy link
Member

@jordienr jordienr commented Oct 22, 2025 •
edited
Loading

  • swaps error rate to success rate
  • adds tests
  • moves some operations to a separate file

BEFORE

CleanShot 2025-10-22 at 15 26 03@2x

AFTER

CleanShot 2025-10-22 at 15 25 23@2x

@jordienr jordienr requested a review from a team as a code owner October 22, 2025 13:24
@supabase
Copy link

supabase bot commented Oct 22, 2025

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@vercel
Copy link

vercel bot commented Oct 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
studio-self-hosted Ready Ready Preview Comment Oct 22, 2025 1:39pm
studio-staging Ready Ready Preview Comment Oct 22, 2025 1:39pm
6 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
studio Ignored Ignored Oct 22, 2025 1:39pm
cms Skipped Skipped Oct 22, 2025 1:39pm
design-system Skipped Skipped Oct 22, 2025 1:39pm
docs Skipped Skipped Oct 22, 2025 1:39pm
ui-library Skipped Skipped Oct 22, 2025 1:39pm
zone-www-dot-com Skipped Skipped Oct 22, 2025 1:39pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025 •
edited
Loading

Studio E2E Results

  • Total: 1
  • Passed: 1
  • Failed: 0
  • Skipped: 0
  • Timed out: 0
  • Interrupted: 0
  • Flaky: 0
  • Duration: 2.5s

Artifacts: https://github.com/supabase/supabase/actions/runs/18717803161

Last updated: Wednesday 22, October, 2025 13:46:07 (UTC)

awaseem
awaseem approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@awaseem awaseem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean!

@jordienr jordienr merged commit a37ae0a into master Oct 22, 2025
19 of 20 checks passed
@jordienr jordienr deleted the jordi/newhome-error-to-success branch October 22, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awaseem awaseem awaseem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jordienr @awaseem