Skip to content

Conversation

@ignaciodob
Copy link
Contributor

@ignaciodob ignaciodob commented Oct 24, 2025

This PR changes the way that we check if the user is allowed to change the compute instance of a project from checking if the user is on the Free Plan to an entitlement check.

Testing

  • Head over to /project/_/settings/compute-and-disk
  • Assert that an Org on the Free Plan cannot change the Compute Size.
  • Assert that an Org on the Free Plan sees the "Compute and Disk configuration is not available on the Free Plan" notice
  • Assert that an Org on the Pro Plan and above can change the Compute Size.

Optional testing with backend feature catalog changes

  • Run your local backend local environment and local studio
  • Modify this line to enabled: true to enable updating compute sizes on the Free Plan.
  • Assert that you're able to select a compute size update on the frontend

@ignaciodob ignaciodob self-assigned this Oct 24, 2025
@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
studio-self-hosted Ready Ready Preview Comment Oct 28, 2025 4:22pm
studio-staging Ready Ready Preview Comment Oct 28, 2025 4:22pm
6 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
studio Ignored Ignored Oct 28, 2025 4:22pm
cms Skipped Skipped Oct 28, 2025 4:22pm
design-system Skipped Skipped Oct 28, 2025 4:22pm
docs Skipped Skipped Oct 28, 2025 4:22pm
ui-library Skipped Skipped Oct 28, 2025 4:22pm
zone-www-dot-com Skipped Skipped Oct 28, 2025 4:22pm

@supabase
Copy link

supabase bot commented Oct 24, 2025

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coveralls
Copy link

coveralls commented Oct 24, 2025

Coverage Status

coverage: 70.088%. first build
when pulling b17cd53 on chore/compute-instances-entitlements
into 406ada7 on master.

@ignaciodob ignaciodob force-pushed the chore/compute-instances-entitlements branch from a428519 to 97420e6 Compare October 24, 2025 14:36
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

Studio E2E Results

Note: No JSON report found or parse error.

Artifacts: https://github.com/supabase/supabase/actions/runs/18881577863

Last updated: Tuesday 28, October, 2025 16:22:31 (UTC)

@ignaciodob ignaciodob force-pushed the chore/compute-instances-entitlements branch from 5baa15d to e439148 Compare October 24, 2025 20:01
@ignaciodob ignaciodob force-pushed the chore/compute-instances-entitlements branch from 8196dc2 to 110ec34 Compare October 26, 2025 13:52
@ignaciodob ignaciodob changed the title Chore: Compute Instances entitlements chore: Compute Instances entitlements Oct 26, 2025
@ignaciodob ignaciodob marked this pull request as ready for review October 26, 2025 14:03
@ignaciodob ignaciodob requested a review from a team as a code owner October 26, 2025 14:03
@ignaciodob ignaciodob changed the title chore: Compute Instances entitlements chore: compute Instances entitlements Oct 26, 2025
Copy link
Contributor

@kevcodez kevcodez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before starting to actually use entitlements in the frontend, let's ensure two things

  • On a plan change or any change that would invalidate entitlements, we need to invalidate the react-query cache
  • Have a higher stale time to avoid refetching (let's do 30m-60m)

@ignaciodob
Copy link
Contributor Author

Before starting to actually use entitlements in the frontend, let's ensure two things

  • On a plan change or any change that would invalidate entitlements, we need to invalidate the react-query cache
  • Have a higher stale time to avoid refetching (let's do 30m-60m)

Addressed in #39905

Copy link
Contributor

@kanishkdudeja kanishkdudeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works as expected.

@ignaciodob ignaciodob enabled auto-merge (squash) October 28, 2025 16:19
@ignaciodob ignaciodob merged commit 26286fd into master Oct 28, 2025
19 of 20 checks passed
@ignaciodob ignaciodob deleted the chore/compute-instances-entitlements branch October 28, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants