Skip to content

Conversation

@dnywh
Copy link
Contributor

@dnywh dnywh commented Nov 5, 2025

What kind of change does this PR introduce?

  • Copywriting improvements

What is the current behavior?

  • Authentication-type email template descriptions are written in passive voice
    • Their true purpose (an/or trigger) is a bit confusing and unclear
  • Security-type email template titles and descriptions were a bit verbose and unclear

What is the new behavior?

  • Each authentication-type email template has had its description rewritten in active voice
  • Each security-type email template has had its title and description tightened

Additional context

Our docs now have slightly different language, but I think this is okay to leave. Those docs should accompany and further expand on what’s in Studio, not simply mirror it. In other words: people go to docs to get more information, not the same.

@dnywh dnywh requested a review from issuedat November 5, 2025 00:43
@dnywh dnywh requested a review from a team as a code owner November 5, 2025 00:43
@vercel
Copy link

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
studio-self-hosted Ready Ready Preview Comment Nov 5, 2025 0:46am
studio-staging Ready Ready Preview Comment Nov 5, 2025 0:46am
6 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
studio Ignored Ignored Nov 5, 2025 0:46am
cms Skipped Skipped Nov 5, 2025 0:46am
design-system Skipped Skipped Nov 5, 2025 0:46am
docs Skipped Skipped Nov 5, 2025 0:46am
ui-library Skipped Skipped Nov 5, 2025 0:46am
zone-www-dot-com Skipped Skipped Nov 5, 2025 0:46am

@supabase
Copy link

supabase bot commented Nov 5, 2025

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

},
MAILER_TEMPLATES_CONFIRMATION_CONTENT: {
title: 'Message body',
title: 'Body',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m renaming this field from Message body to just Body in this PR: #40069

So just matching that here

},
validationSchema: object().shape({
MAILER_SUBJECTS_CONFIRMATION: string().required('Subject heading is required.'),
MAILER_SUBJECTS_CONFIRMATION: string().required('Subject is required.'),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, 'Subject heading' is now just 'Subject' in #40069

description={
organization_slug
? `'This organization has been pre-selected by ${requester?.name}.`
? `This organization has been pre-selected by ${requester?.name}.`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR. Sorry. Just cleaning up an extraneous ' character.

I tested locally and this is just a superficial, copywriting change. If you really want to test it though, see instructions here.

@coveralls
Copy link

Coverage Status

coverage: 70.363%. remained the same
when pulling e705c10 on dnywh/chore/copy-updates
into c474d3d on master.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Studio E2E Results

  • Total: 1
  • Passed: 1
  • Failed: 0
  • Skipped: 0
  • Timed out: 0
  • Interrupted: 0
  • Flaky: 0
  • Duration: 2.5s

Artifacts: https://github.com/supabase/supabase/actions/runs/19087464832

Last updated: Wednesday 5, November, 2025 01:00:31 (UTC)

Copy link
Contributor

@issuedat issuedat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner and makes the wording more consistent! I'll update the docs to use similar wording: #40141

@dnywh dnywh merged commit 5305a7b into master Nov 5, 2025
21 checks passed
@dnywh dnywh deleted the dnywh/chore/copy-updates branch November 5, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants