-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
chore(studio): auth email template copywriting improvements #40163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
6 Skipped Deployments
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
| }, | ||
| MAILER_TEMPLATES_CONFIRMATION_CONTENT: { | ||
| title: 'Message body', | ||
| title: 'Body', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m renaming this field from Message body to just Body in this PR: #40069
So just matching that here
| }, | ||
| validationSchema: object().shape({ | ||
| MAILER_SUBJECTS_CONFIRMATION: string().required('Subject heading is required.'), | ||
| MAILER_SUBJECTS_CONFIRMATION: string().required('Subject is required.'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, 'Subject heading' is now just 'Subject' in #40069
| description={ | ||
| organization_slug | ||
| ? `'This organization has been pre-selected by ${requester?.name}.` | ||
| ? `This organization has been pre-selected by ${requester?.name}.` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR. Sorry. Just cleaning up an extraneous ' character.
I tested locally and this is just a superficial, copywriting change. If you really want to test it though, see instructions here.
|
Studio E2E Results
Artifacts: https://github.com/supabase/supabase/actions/runs/19087464832 Last updated: Wednesday 5, November, 2025 01:00:31 (UTC) |
issuedat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner and makes the wording more consistent! I'll update the docs to use similar wording: #40141
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Additional context
Our docs now have slightly different language, but I think this is okay to leave. Those docs should accompany and further expand on what’s in Studio, not simply mirror it. In other words: people go to docs to get more information, not the same.