Skip to content

Conversation

@kallebysantos
Copy link
Member

@kallebysantos kallebysantos commented Nov 5, 2025

What kind of change does this PR introduce?

Bug fix

What is the current behaviour?

csv file dropzone is handling non file droping

What is the new behavior?

Screen.Recording.2025-11-05.at.19.20.21.mov

@kallebysantos kallebysantos requested a review from a team as a code owner November 5, 2025 18:34
@vercel
Copy link

vercel bot commented Nov 5, 2025

@kallebysantos is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cms Ready Ready Preview Comment Nov 5, 2025 8:40pm
design-system Ready Ready Preview Comment Nov 5, 2025 8:40pm
docs Ready Ready Preview Comment Nov 5, 2025 8:40pm
studio-self-hosted Ready Ready Preview Comment Nov 5, 2025 8:40pm
studio-staging Ready Ready Preview Comment Nov 5, 2025 8:40pm
ui-library Ready Ready Preview Comment Nov 5, 2025 8:40pm
zone-www-dot-com Ready Ready Preview Comment Nov 5, 2025 8:40pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
studio Ignored Ignored Nov 5, 2025 8:40pm

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Thanks for contributing to Supabase! ❤️ Our team will review your PR.

A few tips for a smoother review process:

  • If you have a local version of the repo, run pnpm run format to make sure formatting checks pass.
  • Once we've reviewed your PR, please don't trivially merge master (don't click Update branch if there are no merge conflicts to be fixed). This invalidates any pre-merge checks we've run.

@awaseem
Copy link
Contributor

awaseem commented Nov 5, 2025

Taking a look

@awaseem
Copy link
Contributor

awaseem commented Nov 5, 2025

@kallebysantos you'll need to run linting again, seems like you have some errors there. You can do pnpm run prettier:check inside the studio folder to find them

@kallebysantos
Copy link
Member Author

I took the opportunity to improve visual feedback when dragging a wrong file type.
Attached a demo video on PR description

Copy link
Contributor

@awaseem awaseem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on both self hosted and staging. Looks great!

@awaseem awaseem merged commit 4d31c85 into supabase:master Nov 5, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Column drag in empty table triggers file drop behavior

2 participants