-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
fix: Validate queue names #40290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Validate queue names #40290
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
6 Skipped Deployments
|
|
Studio E2E Results
Artifacts: https://github.com/supabase/supabase/actions/runs/19226474033 Last updated: Monday 10, November, 2025 10:05:12 (UTC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| 'Invalid queue name: must contain only alphanumeric characters, underscores, and hyphens' | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: SQL Injection Through Unvalidated Inputs
The payload and delay parameters are directly interpolated into the SQL query without validation or proper escaping, creating SQL injection vulnerabilities. While queueName is now validated, user-controlled payload strings and numeric delay values can be exploited to inject malicious SQL. The same pattern affects messageId and duration parameters in other mutations.
Issue within the user supplied queue name parameter
Fixes SEC-583
Note
Introduces shared queue name schema/validation, replaces queryName with queueName, and validates names across queue APIs before executing SQL.
QueryNameSchemaandisQueueNameValidinQueues.utils.QueryNameSchematoCreateQueueSheetformname.queryNametoqueueNamein message actions and hooks.archive,read,delete,send,purge,metrics, andmessagesinfinite query; block invalid names before SQL.MessageDetailsPanelactions to passqueueName.preciseMetricsSqlQuery,estimateMetricsSqlQuery).Written by Cursor Bugbot for commit b465a92. This will update automatically on new commits. Configure here.