Skip to content

Conversation

@kemaldotearth
Copy link
Contributor

@kemaldotearth kemaldotearth commented Nov 10, 2025

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

Our charts weren't rendering in our design system app due to a recharts mismatch from different packages. Monorepo things.

Before After
Screenshot 2025-11-10 at 14 33 11 Screenshot 2025-11-10 at 13 56 25

Note

Unifies recharts to 2.15.4 across packages, simplifies design-system component preview, updates LogsBarChart types/docs/demo, and expands ui-patterns exports.

  • Dependencies:
    • Recharts: Standardize to catalog:^2.15.4 across apps/* and packages/* with lockfile updates.
    • Add dayjs to apps/design-system.
  • Design System:
    • components/component-preview.tsx: Simplify preview; remove tabbed view; add collapsible code section (with expand/collapse); streamline suspense fallback.
    • Docs/Demo: logs-bar-chart demo marked use client; data includes warning_count; doc type updated.
  • Charts:
    • ui-patterns/src/LogsBarChart: Type fix for tooltip labelFormatter param; uses dayjs formatting; minor styling/stack logic retained.
  • ui-patterns Exports:
    • Add/expand exports for Banners/* (incl. AnnouncementBanner, LW15Banner, index), CommandMenu telemetry hooks, extensive FilterBar/* modules, McpUrlBuilder/* components/utilities, PopupFrame, Row utilities/components, and CommandMenu/prepackaged/ai/useAiChat.test.

Written by Cursor Bugbot for commit 440b017. This will update automatically on new commits. Configure here.

@kemaldotearth kemaldotearth requested review from a team as code owners November 10, 2025 14:33
@vercel
Copy link

vercel bot commented Nov 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cms Ready Ready Preview Comment Nov 11, 2025 0:52am
design-system Ready Ready Preview Comment Nov 11, 2025 0:52am
docs Ready Ready Preview Comment Nov 11, 2025 0:52am
studio-self-hosted Ready Ready Preview Comment Nov 11, 2025 0:52am
studio-staging Ready Ready Preview Comment Nov 11, 2025 0:52am
ui-library Ready Ready Preview Comment Nov 11, 2025 0:52am
zone-www-dot-com Ready Ready Preview Comment Nov 11, 2025 0:52am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
studio Ignored Ignored Nov 11, 2025 0:52am

@supabase
Copy link

supabase bot commented Nov 10, 2025

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

Studio E2E Results

  • Total: 1
  • Passed: 1
  • Failed: 0
  • Skipped: 0
  • Timed out: 0
  • Interrupted: 0
  • Flaky: 0
  • Duration: 2.4s

Artifacts: https://github.com/supabase/supabase/actions/runs/19266020664

Last updated: Tuesday 11, November, 2025 12:59:28 (UTC)

Copy link
Contributor

@charislam charislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked charts in studio preview and looks OK, didn't look at design system

@coveralls
Copy link

coveralls commented Nov 10, 2025

Coverage Status

coverage: 68.701%. remained the same
when pulling 014f82c on fix/design-system-chart-previews
into cf18948 on master.

Copy link
Contributor

@dnywh dnywh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested /design-system/ and /studio/ locally. Works fine after some package wrangling.

@kemaldotearth kemaldotearth merged commit af98191 into master Nov 11, 2025
24 checks passed
@kemaldotearth kemaldotearth deleted the fix/design-system-chart-previews branch November 11, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants