Skip to content

Conversation

@kemaldotearth
Copy link
Contributor

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

Abstracting and tidying the metric block we added during auth overview design work. This will likely be used elsewhere to display singular metrics, so componentising.

@vercel
Copy link

vercel bot commented Nov 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cms Ready Ready Preview Comment Nov 14, 2025 11:32am
design-system Ready Ready Preview Comment Nov 14, 2025 11:32am
docs Ready Ready Preview Comment Nov 14, 2025 11:32am
studio-self-hosted Ready Ready Preview Comment Nov 14, 2025 11:32am
studio-staging Ready Ready Preview Comment Nov 14, 2025 11:32am
ui-library Ready Ready Preview Comment Nov 14, 2025 11:32am
zone-www-dot-com Ready Ready Preview Comment Nov 14, 2025 11:32am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
studio Ignored Ignored Nov 14, 2025 11:32am

@supabase
Copy link

supabase bot commented Nov 11, 2025

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coveralls
Copy link

coveralls commented Nov 11, 2025

Coverage Status

coverage: 68.718%. remained the same
when pulling 093a6b8 on feat/ds-metrics-card-component
into eaf35c1 on master.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Studio E2E Results

  • Total: 1
  • Passed: 1
  • Failed: 0
  • Skipped: 0
  • Timed out: 0
  • Interrupted: 0
  • Flaky: 0
  • Duration: 1.4s

Artifacts: https://github.com/supabase/supabase/actions/runs/19363144199

Last updated: Friday 14, November, 2025 11:39:45 (UTC)

@kemaldotearth kemaldotearth marked this pull request as ready for review November 13, 2025 12:33
@kemaldotearth kemaldotearth requested a review from a team as a code owner November 13, 2025 12:33
@kemaldotearth kemaldotearth requested a review from a team November 13, 2025 12:44
@kemaldotearth kemaldotearth changed the title feat(design-system): add metrics block component feat(design-system): add <MetricsCard /> component Nov 13, 2025
@dnywh
Copy link
Contributor

dnywh commented Nov 14, 2025

Weird build error on docs:

Module not found: Can't resolve './build/Release/queryparser.node'
> 1 | const PgQuery = require('./build/Release/queryparser.node');
    | ^
  2 |
  3 | module.exports = {
  4 |   parseQuery(query) {

Copy link
Contributor

@dnywh dnywh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved but two things to probably investigate:

  • Light mode text legibility
    • Non-blocking as I see it predates your work here
  • Error on docs build
    • Could be unrelated or inconsequential

@kemaldotearth kemaldotearth merged commit 06ac401 into master Nov 14, 2025
20 of 21 checks passed
@kemaldotearth kemaldotearth deleted the feat/ds-metrics-card-component branch November 14, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants