Skip to content

Conversation

@7ttp
Copy link

@7ttp 7ttp commented Nov 20, 2025

updates the upserting into tables with constraints example to show the correct response, and adds the missing onConflict option to the return-the-exact-number-of-rows example.

i have read the contributing.md file:
yes

what kind of change does this pr introduce?
docs update

what is the current behavior?
the upsert docs show an incorrect response example and the second example is missing the onConflict option.

what is the new behavior?
the first example shows the correct response, and the second example includes the onConflict option so both examples match expected behavior.

additional context:
fixes #40653

updates the upserting into tables with constraints example to show the correct response
and adds the missing onConflict option to the return-the-exact-number-of-rows example
@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
design-system Skipped Skipped Nov 20, 2025 4:57pm

@vercel
Copy link

vercel bot commented Nov 20, 2025

@7ttp is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

Thanks for contributing to Supabase! ❤️ Our team will review your PR.

A few tips for a smoother review process:

  • If you have a local version of the repo, run pnpm run format to make sure formatting checks pass.
  • Once we've reviewed your PR, please don't trivially merge master (don't click Update branch if there are no merge conflicts to be fixed). This invalidates any pre-merge checks we've run.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 20, 2025
@7ttp 7ttp changed the title update upsert example response and option updated upsert example response and option Nov 20, 2025
@7ttp
Copy link
Author

7ttp commented Nov 21, 2025

@mandarini

@mandarini
Copy link
Contributor

@7ttp thank you for this. Can you please move these examples in tsdoc in the https://github.com/supabase/supabase-js repo?

We are going some changes on how docs are rendered and that would be super helpful.

Example syntax: https://typedoc.org/documents/Tags._example.html

@7ttp
Copy link
Author

7ttp commented Nov 21, 2025

@mandarini Done, moved the examples as requested!

@mandarini
Copy link
Contributor

Thank you!

@mandarini mandarini closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in documentation in "upsert"

2 participants